Difference between revisions of "User:Amritpal singh/GSoC17/logs"

(Coding Period)
(Coding Period)
(10 intermediate revisions by the same user not shown)
Line 216: Line 216:
<li>Added description image in Bent shape rebar. [https://github.com/amrit3701/FreeCAD-Reinforcement/commit/b7ad0889efa07415dba2551a85a78ab407c2796d Commit]
<li>Added description image in Bent shape rebar. [https://github.com/amrit3701/FreeCAD-Reinforcement/commit/b7ad0889efa07415dba2551a85a78ab407c2796d Commit]
<li>Fixed bug: No reaction on changing diameter in LShape, UShape and Bent shape rebar. For detail, here is the discussion: https://forum.freecadweb.org/viewtopic.php?f=34&t=23637&p=186052#p186052
<li>Fixed bug [https://github.com/amrit3701/FreeCAD-Reinforcement/commit/ea3e56f6059a69b15f1dc0bb2fb5a26e0d0048ea Commit]: No reaction on changing diameter in LShape, UShape and Bent shape rebar. For detail, here is the discussion: https://forum.freecadweb.org/viewtopic.php?f=34&t=23637&p=186052#p186052</li>
[https://github.com/amrit3701/FreeCAD-Reinforcement/commit/ea3e56f6059a69b15f1dc0bb2fb5a26e0d0048ea Commit]</li>
<li>Implemented <code>Part::Helix</code> in circular(helical) rebar. [https://github.com/amrit3701/FreeCAD-Reinforcement/commit/888377bc01e6ff0e21fba187bf6821eb46c4c26b Commit]
<li>Implemented <code>Part::Helix</code> in circular(helical) rebar. [https://github.com/amrit3701/FreeCAD-Reinforcement/commit/888377bc01e6ff0e21fba187bf6821eb46c4c26b Commit]
'''12-13 August''':<ul><li>Added detail description icons of Striaght, LShape and Stirrup rebar (made by thschrader). [https://github.com/amrit3701/FreeCAD-Reinforcement/commit/e18c04a066cb2725de3643e4e6b747952b11efb0 Commit]</li>
<li>Added rebar tool dropdown list icons of bent shape and helical rebar (made by Yorik). [https://github.com/amrit3701/FreeCAD-Reinforcement/commit/2de16ede89c889b8661b90a5ed62d38c57bba32b Commit]</li>
<li>Created first wiki page on UShape rebar. [https://www.freecadweb.org/wiki/Arch_Rebar_UShape Link]</li></ul>
'''14-18 August''':<ul><li>Added help icon in all rebar dialogs. [https://github.com/amrit3701/FreeCAD-Reinforcement/commit/0b1b5268763d65bd9400516366c6139a179d5395 Commit]</li>
<li>Updated detailed description icon of helical rebar. [https://github.com/amrit3701/FreeCAD-Reinforcement/commit/9946f98d5074e96908eb2cab5cae5c7bcc664241 Commit]</li>
<li>Replace Circular Stirrup name to Helical Rebar. [https://github.com/amrit3701/FreeCAD-Reinforcement/commit/6051eae0f588ea6d7f7f051a95ffe975326cbc51 Commit]</li>
<li>Created wiki pages(user documentation) for all rebar shapes. See given below:
<ul><li>Straight Rebar: [https://www.freecadweb.org/wiki/Arch_Rebar_Straight User_Documentation]</li>
<li>UShape Rebar:[https://www.freecadweb.org/wiki/Arch_Rebar_UShape User_Documentation]</li>
<li>LShape Rebar: [https://www.freecadweb.org/wiki/Arch_Rebar_LShape User_Documentation]</li>
<li>Bent Shape Rebar: [https://www.freecadweb.org/wiki/Arch_Rebar_BentShape User_Documentation]</li>
<li>Stirrup: [https://www.freecadweb.org/wiki/Arch_Rebar_Stirrup User_Documentation]</li>
<li>Helical Rebar: [https://www.freecadweb.org/wiki/Arch_Rebar_Helical User_Documentation]</li></ul></ul>
'''19 August''': <ul><li>Added comments in StraightRebar.py, BentShapeRebar.py and HelicalRebar.py. [https://github.com/amrit3701/FreeCAD-Reinforcement/commit/a6702034e9bed4a7443e7179558b007e1db658dc Commit]</li></ul>
'''20 August''': <ul><li>Added comments in UShapeRebar.py, LShapeRebar.py and Stirrup.py and Rebarfunc.py. [https://github.com/amrit3701/FreeCAD-Reinforcement/commit/48c57088c3463e5cbff2a33e1c3583297dfb53aa Commit]</li></ul>
'''21 August''': Discussed few things related to rebar addon code with Yorik on IRC.
'''22 August''': Added support in LShape dialog to take custom spacing when a user create rebar. [https://github.com/amrit3701/FreeCAD-Reinforcement/commit/1bad73492e13fe8fc4e96e915e4f085712efacd2 Commit]
'''23 August''': Also enabled custom spacing button in rest of rebar dialog. [https://github.com/amrit3701/FreeCAD-Reinforcement/commit/7cc53c21f304566a5c911959edbbd820ac971a49 Commit]
'''24-26 August''': Update README.md file on GitHub repo. [https://github.com/amrit3701/FreeCAD-Reinforcement/commit/ddba8be594a3abb262b4377946f1d7771ce118bc Commit]
'''27 August''': Filled GSoC final evaluation form.

Latest revision as of 02:42, 28 August 2017

Community Bonding Period[edit]

  • Discussion of a project on FreeCAD forum and on IRC.
  • Compile Qt plugin of FreeCAD to load FreeCAD widgets in QT creator.
  • Understanding the code of ArchRebar object.
  • Added PlacementList property to the rebar object. The PlacementList holds the placement of all the rebars. Pull request.

Coding Period[edit]

1 June : Today, officially my all exams are over and from now onwards I will give my 100 percent to my GSoC project. I have written TODO tasks for upcoming two weeks.

2 June : I have found a couple of shortcomings bugs in my scripts which I have shared before community bonding period. Also discussed these bugs with my mentor.

3 June : Yesterday, Yorik (my mentor) gave some suggestion that how to fix these bugs. Today, I was trying to make the logic which will work on any type of reinforcement and trying to implement that logic through programming. Also, explored functions like face.normalAt(), face.CenterOfMass().

4 June : Today, I designed the taskpanel UI of straight rebar in Qtcreator by using FreeCAD widgets.

Straightrebar taskpanel.png

5 June : Today, I have integrated the task panel UI of straight rebar with backend scripts. This script will take input values from task panel and then pass input values to makeStraightRebar() function which will create reinforcement of straight rebar in the structural element. For more detail, here are my commits.

6 June : Today, I have shared my scripts to the mentor for review. Here are the reviews: https://forum.freecadweb.org/viewtopic.php?f=8&t=22760&sid=edc3a89eda2a484d1af55128b1781e6b#p177059

7 June : Today, I have learnt that how to add an image in the dialog box using PySide. For eg. I simply added QLabel object at the top of the dialog box using Qtcreator and then use label.setPixmap(QtGui.QPixmap(<path>)) command to add an image. Also, followed some links/tutorials to learn Inkscape.

Straightrebar image.png

8 June : Today, I have added checks to my Python code. These checks will verify that user have selected the face or not and if only user have selected a single face then only rebar object is created. Commit

9-10 June:

  • Discussed my approach with structural engineers and found the right way to create reinforcement in the structural element. Link
  • Sent pull request to FreeCAD (master).

11 June: Not done too much, finalised what has done till now and made a planned for things coming in the next weeks.

12 June: Discussed following things with Yorik:

  • How to get previous values (when reinforcement is created) when a user wants to re-edit the current reinforcement?
    • Add properties to the rebar object.
    • Constraint the sketch of the rebar object.
  • How we can check the given sketch is rectangular or not?

13 June:

  • Understand functions present in a file.
  • Added support when Structural element is derived from Sketch object.
  • Defined EdgesAngle(edge1, edge2), checkRectangle(edges) functions.

Here is the commit.

14 June:

  • Solved a issue related to the placement of rebar. For e.g., Rebar position was not at correct position when structural element not located at orign. So, to fix this problem I have subtracted placement vector of structural element to the coordinates of rebar sketch.
  • Defined getBaseObject(obj), getBaseStructuralObject(obj) functions.
  • Refactored the code by creating the seperate file "Rebarfunc.py". This file contains basic functions which will use for creating any type reinforcement in the future.

15-16 June:

  • Sent pull request to FreeCAD master. Detail of PR: Defined custom function (setpropertyRebarShape) in the _ViewProviderRebar class. This function will add properties to the instance of _ViewProviderRebar class as per according to the rebar shape.
  • Wrote code so that user will re-edit the rebar through rebar dialog box. To implement this, I have defined two new methods editDialog() and editStraightRebar() in the StraighRebar.py file.
  • Also added a couple of methods (getTrueParametersOfStructure(), getParametersOfFace()) in the Rebarfunc.py file.
  • Removed minor bugs in the existing code.

Here is the commit.

17 June:

  • Fix bug and added comments in the StraightRebar.py and Rebarfunc.py files. Commit
  • Updated README.md Commit
  • Imporoved of UI of dialog box of straight rebar and also set tab order on input fields of straight rebar dialog box.Commit

18 June: Today, a whole I was struggling to find a reason behind why rebar created in a wrong direction when user set an option "remove external geometry of base sketches when needed" in the Arch preferences. Finally, I found a reason behind this bug and then fix it. Commit

19 June:

  • Fix bug when user created reinforcement more than one times on the same structural element, rebar was not created at right position. Commit
  • Discussed with Yorik on IRC, that where we can add properties of rebar and then after discussion I am added all the properties to a specific rebar shape as per according to rebar shape. Commit
  • Created the UI dialog box for U-Shape rebar
  • Also wrote a code for creating U-Shape rebar. Commit

20 June:

  • Implemented property top cover in U-Shape rebar instead of bent lenght.Commit
  • Made an icon for U-Shape rebar and also improved Straight rebar icon.
  • Straightrebar5.png

21 June:

  • Added two FreeCAD command (Arch_Rebar_Straight, Arch_Rebar_UShape) in the RebarTools.py file. Commit

22 June:

  • Changed a title window heading of dialog box.
  • Used standard button instead of custom button
  • Assigned tasks which I will complete in the coming week.

Here is a commit.

23 June:

24-25 June:

  • Create a UI of dialog box of stirrup shape rebar. Commit
  • Experimenting how to create non-planar rebar because current FreeCAD reinforcement system is fully dependent on sketch which is strictly based on 2D. Then found a solution to create non-planar rebar by passing wire(may be planar or non-planar) to Arch.makeRebar() function.
  • Also found some bugs which will come by using wire profile to create rebar. Link

26-27 June:

  • Discussed about old and new properties of Rebar object like distance and direction properties and implemented on Rebar object with Yorik
  • Derived formula to get points when length and angle is given

28 June:

  • Wrote code of Stirrup.py file. Commit
  • Discussed doubts regarding stirrup with Yorik on IRC.

29 June:

  • Learnt all the mathematical concepts of stirrup and derives formulas to find rounding length.
  • Embedded dropdown list icons in my code. Commit

30 June:

  • Today, I have passed my first evaluation and got some good comments from my mentors.
  • I have wrote the code for stirrup rebar. Commit

Here are the few screenshots of stirrup created from my code:


1 July:

  • Refactoring the existing code by added two seperate functions which calculates points of Straight and U-Shape rebar. Commit
  • Added License to all the files. Commit

2 July:

3-4 July:

  • Introduced new property i.e. Bent Factor property in Stirrup. Commit
  • Discussed about bar distribution on forum and IRC.

5-6 July:

  • Implementated "Pick Selected Face" button in all rebar shapes. Commits: 1, 2
  • Updated getParametersOfFace() function according to Yorik's commit in the FreeCAD master. Change
  • Introduced new custom spacing property in the Rebar object.

7 July:

  • Sent PR to FreeCAD master and Yorik merged my PR. Pull Request
  • Added PickFaceSelectedLabel in all UI files. Commit
  • Added Stirrup Rebar icon in dropdown list. Commit

8 July:

  • Designed a UI for rebar distribution. Commit
  • Saw rebar distribution in Tekla Structures and also found some bugs in Tekla rebar distribution.

9 July:

  • Wrote code for implementing rebar distribution. Commit

10-11 July:

  • Made an icon for dialog box of rebar distribution.
  • Added button for custom spacing in straight rebar dialog box and also added few function in RebarDistribution.py file. Commit
  • Implemented uniform spacing in all rebar dialog box with a proper way. Commit

12 July:

  • Discussed about rebar distibution dialog box on the FreeCAD forum with all FreeCAD testers and also explained how rebar distribution works.

13-14 July:

  • Added support to rebar add-on when structure element is derived from any object(like wire, sketch etc.). Commit
  • Also, read about direction of cosine and exploring properties of edges, faces and boundingbox.

15 July:

  • Added comments in Rebarfunc.py file. Commit
  • Fix bug when user selects face whose length and width are equal. Commit
  • As said my mentor, I added line in the code which change Label property to reflect rebar type(Straight Rebar, Stirrup Rebar etc) in the tree view.
  • Create UI file for L-Shape rebar.

16 July:

  • Wrote code of L-Shape rebar. Commit
  • Create differents icons of L-Shape rebar which shows orientation of rebar. Commit
  • Added return statement in all make rebar functions. Commit
  • Also screencast a video of L-Shape rebar. Video

17-19 July:

  • Imporved geometry of stirrup rebar. Commit
  • Defined [code]translate()[/code] function in Rebarfunc.py file as said by Yorik.
  • Discussed many things with Yorik on IRC related to Rebar-Addon.

20 July:

  • Added orientation property and separated side cover into parts i.e. left and right side cover. Commit
  • Separate side cover of stirrup into left, right, top and bottom side cover. Commit

21-22 July:

  • Created different icons of U-Shape rebar according to the orientation property. Commit
  • Separated side cover of L-Shape rebar into left and right side cover. Commit
  • Introduced many new properties in straight rebar. The fields present in the straight rebar dialog box is changing according to orientation and cover along property.Commit

23 July: Didn't do too much just create icon of straight rebar when orientation is set to vertical. Commit

24 July: Discussed many new things regarding the drawing of a structural element with Yorik on IRC. https://forum.freecadweb.org/viewtopic.php?f=8&t=22760&start=150#p183274

25 July: Found one bug in Chakkree's script and fixed it. Here is the discussion: Forum Link

26 July:

  • I watched Regis stair reinforcement video.
  • Fixed a bug regarding the direction of stirrup expand when a user selected base face of the structural element. Commit

27-29 July:

  • Created UI for bent up rebars. Commit
  • Implemented bent up rebar. Commit
  • Bentrebar.png

30-31 July: Didn't do anything. Took rest for two days.

1 Augest:

  • Created dialog box for pop up image and implemented it. Commit
  • PopimageUshapeRebar.png

2-4 Augest:

  • Read Chakkree's code for implementing circular stirrup. Code
  • Created UI of Circular stirrup. Commit
  • Wrote code in CircularStirrup.py file. Commit
  • Discussed issues related to circular stirrup with Yorik which comes when I set Part::Helix as a base of rebar object.

5 Augest: GSoC party!.

6 Augest:

7-11 August

  • Discussed issue related to helical rebar shape on passing Part::Helix object as base object of Rebar on IRC.
  • Implemented "Apply" button in all rebars dialog boxs. Commit
  • Added description image in Bent shape rebar. Commit
  • Fixed bug Commit: No reaction on changing diameter in LShape, UShape and Bent shape rebar. For detail, here is the discussion: https://forum.freecadweb.org/viewtopic.php?f=34&t=23637&p=186052#p186052
  • Implemented Part::Helix in circular(helical) rebar. Commit

12-13 August:

  • Added detail description icons of Striaght, LShape and Stirrup rebar (made by thschrader). Commit
  • Added rebar tool dropdown list icons of bent shape and helical rebar (made by Yorik). Commit
  • Created first wiki page on UShape rebar. Link

14-18 August:

19 August:

  • Added comments in StraightRebar.py, BentShapeRebar.py and HelicalRebar.py. Commit

20 August:

  • Added comments in UShapeRebar.py, LShapeRebar.py and Stirrup.py and Rebarfunc.py. Commit

21 August: Discussed few things related to rebar addon code with Yorik on IRC.

22 August: Added support in LShape dialog to take custom spacing when a user create rebar. Commit

23 August: Also enabled custom spacing button in rest of rebar dialog. Commit

24-26 August: Update README.md file on GitHub repo. Commit

27 August: Filled GSoC final evaluation form.