Editing User:Amritpal singh/GSoC17/logs

=Community Bonding Period=
---------------------------
* Discussion of a project on FreeCAD forum and on IRC.
* Compile Qt plugin of FreeCAD to load FreeCAD widgets in QT creator.
* Understanding the code of [https://github.com/FreeCAD/FreeCAD/blob/master/src/Mod/Arch/ArchRebar.py ArchRebar] object. 
* Added PlacementList property to the rebar object. The PlacementList holds the placement of all the rebars. [https://github.com/FreeCAD/FreeCAD/pull/780 Pull request]. 
--------------------------------------------


=Coding Period=
----------------

'''1 June''' : Today, officially my all exams are over and from now onwards I will give my 100 percent to my GSoC project. I have written TODO tasks for upcoming two weeks.

'''2 June''' : I have found a couple of shortcomings [https://forum.freecadweb.org/viewtopic.php?f=8&t=22760#p176641 bugs] in my scripts which I have shared before community bonding period. Also discussed these bugs with my mentor.

'''3 June''' : Yesterday, Yorik (my mentor) gave some suggestion that how to fix these [https://forum.freecadweb.org/viewtopic.php?f=8&t=22760#p176641 bugs]. Today, I was trying to make the logic which will work on any type of reinforcement and trying to implement that logic through programming. Also, explored functions like <code>face.normalAt()</code>, <code>face.CenterOfMass()</code>.

'''4 June''' : Today, I designed the taskpanel UI of straight rebar in Qtcreator by using FreeCAD widgets.[[File:straightrebar_taskpanel.png|frame|center|200px]]

'''5 June''' : Today, I have integrated the task panel UI of straight rebar with backend scripts. This script will take input values from task panel and then pass input values to <code>makeStraightRebar()</code> function which will create reinforcement of straight rebar in the structural element. For more detail, here are my [https://github.com/amrit3701/FreeCAD-Reinforcement/commit/21c427118a7e502a9a04240fe8ea10661ff45794 commits].

'''6 June''' : Today, I have shared my scripts to the mentor for review.
Here are the reviews: https://forum.freecadweb.org/viewtopic.php?f=8&t=22760&sid=edc3a89eda2a484d1af55128b1781e6b#p177059

'''7 June''' : Today, I have learnt that how to add an image in the dialog box using PySide. For eg. I simply added QLabel object at the top of the dialog box using Qtcreator and then use <code>label.setPixmap(QtGui.QPixmap(<path>))</code> command to add an image. Also, followed some links/tutorials to learn Inkscape.
[[File:Straightrebar_image.png|frame|center|200px]]

'''8 June''' : Today, I have added checks to my Python code. These checks will verify that user have selected the face or not and if only user have selected a single face then only rebar object is created. [https://github.com/amrit3701/FreeCAD-Reinforcement/commit/c329b018a2c28538174f006ac55f057bf35f5de0 Commit]

'''9-10 June''': <ul><li>Discussed my approach with structural engineers and found the right way to create reinforcement in the structural element. [https://forum.freecadweb.org/viewtopic.php?f=8&t=22760&p=177570#p177570 Link]</li>
<li>Sent [https://github.com/FreeCAD/FreeCAD/pull/811 pull request] to FreeCAD (master).</li></ul>

'''11 June''': Not done too much, finalised what has done till now and made a planned for things coming in the next weeks.

'''12 June''': Discussed following things with Yorik:
<ul><li>How to get previous values (when reinforcement is created) when a user wants to re-edit the current reinforcement?</li>
<ul><li>Add properties to the rebar object.</li>
<li>Constraint the sketch of the rebar object.</li></ul>
<li>How we can check the given sketch is rectangular or not?</li>
</ul>

'''13 June''': <ul><li>Understand functions present in a [http://free-cad.sourceforge.net/SrcDocu/df/df4/fcgeo_8py_source.html file].</li>
<li>Added support when Structural element is derived from Sketch object.</li>
<li>Defined <code>EdgesAngle(edge1, edge2)</code>, <code>checkRectangle(edges)</code> functions.
</ul>
Here is the [https://github.com/amrit3701/FreeCAD-Reinforcement/commit/1c2b0c299eb91592ab2c6011ff50535e43438eaf commit].

'''14 June''': <ul><li>Solved a issue related to the placement of rebar. For e.g., Rebar position was not at correct position when structural element not located at orign. So, to fix this problem I have subtracted  placement vector of structural element to the coordinates of rebar sketch.</li>
<li>Defined <code>getBaseObject(obj)</code>, <code>getBaseStructuralObject(obj)</code> functions.</li>
<li>Refactored the code by creating the seperate file "Rebarfunc.py". This file contains basic functions which will use for creating any type reinforcement in the future.</li>
</ul>

'''15-16 June''': <ul><li>Sent [https://github.com/FreeCAD/FreeCAD/pull/822 pull request] to FreeCAD master. Detail of PR: Defined custom function (setpropertyRebarShape) in the _ViewProviderRebar class. This function will add properties to the instance of _ViewProviderRebar class as per according to the rebar shape.</li>
<li>Wrote code so that user will re-edit the rebar through rebar dialog box. To implement this, I have defined two new methods <code>editDialog()</code> and <code>editStraightRebar()</code> in the StraighRebar.py file.
<li>Also added a couple of methods (<code>getTrueParametersOfStructure()</code>, <code>getParametersOfFace()</code>) in the Rebarfunc.py file.
<li>Removed minor bugs in the existing code.</li> </ul>

Here is the [https://github.com/amrit3701/FreeCAD-Reinforcement/commit/7efc536ae2be260496b36bc44ba95fadd94626ab commit].

'''17 June''':<ul><li>Fix bug and added comments in the StraightRebar.py and Rebarfunc.py files. [https://github.com/amrit3701/FreeCAD-Reinforcement/commit/f2fc06a7071d75f6153421f88bf3ec57fb3fe41f Commit]</li>
<li>Updated README.md [https://github.com/amrit3701/FreeCAD-Reinforcement/commit/001ebb1e55025a0cac8ac7998657a196b992626a Commit]</li>
<li>Imporoved of UI of dialog box of straight rebar and also set tab order on input fields of straight rebar dialog box.[https://github.com/amrit3701/FreeCAD-Reinforcement/commit/29719cee9a696884a23aa8a951b3b8728a36e04f Commit]</li>
</ul>

'''18 June''': Today, a whole I was struggling to find a reason behind why rebar created in a wrong direction when user set an option "remove external geometry of base sketches when needed" in the Arch preferences. Finally, I found a reason behind this bug and then fix it. [https://github.com/amrit3701/FreeCAD-Reinforcement/commit/0397796b38008254f3d60168f05bd3d3582dde80 Commit]

'''19 June''': <ul><li>Fix bug when user created reinforcement more than one times on the same structural element, rebar was not created at right position.
 [https://github.com/amrit3701/FreeCAD-Reinforcement/commit/2e32eed6aefb2fd8f0d209148ae9eb8287ca4e4b Commit]</li>
<li>Discussed with Yorik on IRC, that where we can add properties of rebar and then after discussion I am added all the properties to a specific rebar shape as per according to rebar shape. [https://github.com/amrit3701/FreeCAD-Reinforcement/commit/8b4213987b9ab0402999fab673bce27c4c330678 Commit]</li>
 <li>Created the UI dialog box for U-Shape rebar</li>
<li>Also wrote a code for creating U-Shape rebar. [https://github.com/amrit3701/FreeCAD-Reinforcement/commit/24e195d94d46f6c4909d75f7ad9f5a160232fd63 Commit]</li>
</ul>

'''20 June''': 
<ul><li>Implemented property top cover in U-Shape rebar instead of bent lenght.[https://github.com/amrit3701/FreeCAD-Reinforcement/commit/02966c63e3ce4accae512c20561e3a2bfaf2d9db Commit]</li>
<li>Made an icon for U-Shape rebar and also improved Straight rebar icon.</li>
[[File:Straightrebar5.png|thumbnail|center|150px]]
[[File:U-shaperebar.png|thumbnail|center|150px]]
</ul>


'''21 June''':<ul><li>Added two FreeCAD command (<code>Arch_Rebar_Straight</code>, <code>Arch_Rebar_UShape</code>) in the RebarTools.py file. [https://github.com/amrit3701/FreeCAD-Reinforcement/commit/30d7b60182c1fda8f6310aeee0da1c3a94ba4e69 Commit]</li></ul>

'''22 June''':<ul><li>Changed a title window heading of dialog box.</li>
<li>Used standard button instead of custom button</li>
<li>Assigned tasks which I will complete in the coming week.</li>
</ul>
Here is a [https://github.com/amrit3701/FreeCAD-Reinforcement/commit/5d9467eacdc2c769703c37dfdb4bacaee6cad3b4 commit].

'''23 June''':<ul><li>Added checks when sketch support is empty. [https://github.com/amrit3701/FreeCAD-Reinforcement/commit/70dbced59d68cef6c13c07b238b8a0e3cee3b4fb Commit]</li>
<li>Learnt how to Constraint Internal Angle between two lines.
 (https://www.freecadweb.org/wiki/Constraint_InternalAngle)</li>
<li>Added comment to code. [https://github.com/amrit3701/FreeCAD-Reinforcement/commit/cbef50b7c4484a8e9002a2b9af18e0b1c38f2b29 Commit]</li>
<li>Discussed about license with Yorik.</li>
</ul>

'''24-25 June''':<ul><li>Create a UI of dialog box of stirrup shape rebar. [https://github.com/amrit3701/FreeCAD-Reinforcement/commit/46c7ea56737bb3c9852459355fb5f54fa6731666 Commit]</li>
<li>Experimenting how to create non-planar rebar because current FreeCAD reinforcement system is fully dependent on sketch which is strictly based on 2D. Then found a solution to create non-planar rebar by passing wire(may be planar or non-planar) to <code>Arch.makeRebar()</code> function.</li>
<li>Also found some bugs which will come by using wire profile to create rebar. [https://forum.freecadweb.org/viewtopic.php?f=8&t=23113 Link]</li></ul>

'''26-27 June''': <ul><li>Discussed about old and new properties of Rebar object like distance and direction properties and implemented on Rebar object with Yorik</li>
<li>Derived formula to get points when length and angle is given</li>
</ul>

'''28 June''': <ul><li>Wrote code of Stirrup.py file. [https://github.com/amrit3701/FreeCAD-Reinforcement/commit/eb9c65954c9f1d22b1c8dc881ba4d0eaa1be7515 Commit]</li>
<li>Discussed doubts regarding stirrup with Yorik on IRC.</li> 
</ul>

'''29 June''':<ul><li>Learnt all the mathematical concepts of stirrup and derives formulas to find rounding length.[[File:Stirrup.jpg|thumbnail|center|800px]]</li>
<li>Embedded dropdown list icons in my code. [https://github.com/amrit3701/FreeCAD-Reinforcement/commit/1a45628fc4478601eac357dcf0455be04dd8e909 Commit]</li>
</ul>

'''30 June''':<ul><li>Today, I have passed my first evaluation and got some good comments from my mentors.</li>
<li>I have wrote the code for stirrup rebar. [https://github.com/amrit3701/FreeCAD-Reinforcement/commit/660cd715990af7ae1d94d45935b4ac82676874cf Commit]</li>
</ul>

Here are the few screenshots of stirrup created from my code:
[[File:stirrup1.png|thumbnail|center|200px]]
[[File:stirrup2.png|thumbnail|center|200px]]

'''1 July''': <ul><li>Refactoring the existing code by added two seperate functions which calculates points of Straight and U-Shape rebar. [https://github.com/amrit3701/FreeCAD-Reinforcement/commit/cdd5d8707db0eb9aa0ba28b9e3703ac3e9261e7b Commit]</li>
<li>Added License to all the files. [https://github.com/amrit3701/FreeCAD-Reinforcement/commit/857f0ac46fb3a964169690a772e4904bf80f937a Commit]</li></ul>

'''2 July''': <ul><li>Read the code of [https://github.com/FreeCAD/FreeCAD/blob/master/src/Mod/Part/Gui/TaskThickness.cpp TaskThickness.cpp] file.</li>
<li>Implemented "Pick Selected Face" button in the straight rebar. [https://github.com/amrit3701/FreeCAD-Reinforcement/commit/e59ab8d65e762432152b3213463998daffef9c67 Commit]</li></ul>

'''3-4 July''': <ul><li>Introduced new property i.e. Bent Factor property in Stirrup. [https://github.com/amrit3701/FreeCAD-Reinforcement/commit/6f013f2f7c8dac4175ef72101e4ad14e24185bfb Commit]</li>
<li>Discussed about bar distribution on forum and IRC.</li></ul>

'''5-6 July''': <ul><li>Implementated "Pick Selected Face" button in all rebar shapes. Commits: [https://github.com/amrit3701/FreeCAD-Reinforcement/commit/f2dd3c23381af4a827605c573304dc78d161bae5 1], [https://github.com/amrit3701/FreeCAD-Reinforcement/commit/c19c7a91281ac07eba96106b753b237df4a8d515 2]</li>
<li> Updated <code>getParametersOfFace()</code> function according to Yorik's commit in the FreeCAD master. [https://github.com/amrit3701/FreeCAD-Reinforcement/commit/c19c7a91281ac07eba96106b753b237df4a8d515#diff-2b102af403a2e140e40c12a0d845efd2R143 Change]</li>
<li> Introduced new custom spacing property in the Rebar object.</li></ul>

'''7 July''': <ul><li>Sent PR to FreeCAD master and Yorik merged my PR. [https://github.com/FreeCAD/FreeCAD/pull/862 Pull Request]</li>
<li> Added PickFaceSelectedLabel in all UI files. [https://github.com/amrit3701/FreeCAD-Reinforcement/commit/408b0244b2a8b18ca4ddc62c2764e30b25678a8e Commit]</li>
<li>Added Stirrup Rebar icon in dropdown list. [https://github.com/amrit3701/FreeCAD-Reinforcement/commit/4421504b05ea4c095802c887f578029641a8e98c Commit]</li></ul>

'''8 July''': <ul><li>Designed a UI for rebar distribution. [https://github.com/amrit3701/FreeCAD-Reinforcement/commit/8f77ded1cd11cbd76a08450c0f7b1736f186bf04 Commit]</li>
<li>Saw rebar distribution in Tekla Structures and also found some bugs in Tekla rebar distribution.</li></ul>