Fix any failing unit testBRL-CAD
Status: ClosedTime to complete: 100 hrs Mentors: Hardeep Singh Rai, Gauravjeet SinghTags: c, validation, code, testing, verification

We have a lot of unit tests. These tests help ensure proper functionality. Sometimes we add new tests and either 1) the test itself has an error or 2) the test exposes an error in our implementation. We have a few right now that report an error and someone needs to figure out if it's because of reason #1 or reason #2, and then fix the error so the test succeeds.

We will keep adding more tasks like this until there are no more failures. There are also tasks for adding more unit tests.

This task involves compiling BRL-CAD, running "make test", and fixing any of the failing unit tests properly. Your fix should repair all of the issues in any given file.

You'll want to first build BRL-CAD from a source tree checkout (see http://brlcad.org/wiki/Compiling) either directly from our repository or using the provided virutal machine (see http://brlcad.org/wiki/Deuces for setup instructions). Compile BRL-CAD, then run our unit tests ("make test" on unix, or select the "test" target on other platforms).

Make sure any changes you make compile cleanly and fix the error.

Submit a summary analysis / description of what the error you fixed was, why it was failing, and what you did to fix it.

Submit your changes as a patch file (you can run "svn diff my_changes.patch").

References:
  • http://brlcad.org/wiki/Compiling
  • http://brlcad.org/wiki/Deuces
Modify:
  • The tests are all in subdirectories, so you can find them easily:
  • src/libbu/tests
  • src/libbn/tests
  • src/librt/tests
  • etc... fix one that is failing.
Uploaded Work
File name/URLFile sizeDate submitted
task-14-fix-bu-color-tests.diff2.3 KBDecember 07 2014 20:40 UTC
task-14-fix-bu-color-tests-v2.diff1.6 KBDecember 07 2014 22:07 UTC
Comments
Andromeda Galaxyon December 7 2014 19:41 UTCTask Claimed

I would like to work on this task.

Deepak on December 7 2014 19:43 UTCTask Assigned

This task has been assigned to Andromeda Galaxy. You have 100 hours to complete this task, good luck!

Andromeda Galaxyon December 7 2014 20:40 UTCReady for review

The work on this task is ready to be reviewed.

Andromeda Galaxyon December 7 2014 22:08 UTCNew diff

Sorry, I (accidentally) committed the test data changes earlier; the second version of the patch should apply cleanly.

Sean on December 8 2014 04:06 UTCTask Closed

Congratulations, this task has been completed successfully.

Sean on December 8 2014 04:08 UTCno worries

No worries, thanks for the fix!  Quite clear what the bug was, and demonstrates the dangers of casting.