Run CoreInterface unit testBRL-CAD
Status: ClosedTime to complete: 100 hrs Mentors: Popescu Andrei, Daniel_RTags: unit test, library, oop, testing, C++

This is a follow-on task to https://www.google-melange.com/gci/task/view/google/gci2014/5832406154084352.

The C++ Object-oriented API, called CoreInterface aims to provide an easier-to-use, object-oriented interface over the very powerful BRL-CAD core.

You can check out the core interface code from our subversion repository: svn checkout https://svn.code.sf.net/p/brlcad/code/rt^3/trunk rt^3

  1. Apply the patch from https://www.google-melange.com/gci/task/view/google/gci2014/5832406154084352.
  2. Build the core interface test (make tester_ci_primitives). This is the most challenging part because you have to fix all the errors to make it compile.
  3. Run the test (make test).
  4. Provide a file with the corrected patch from the previous task and the output of the test run.

References:
  • https://www.google-melange.com/gci/task/view/google/gci2014/5832406154084352
  • http://brlcad.org/wiki/BRL-CAD%27s_core_C%2B%2B_interface
Uploaded Work
File name/URLFile sizeDate submitted
http://www.google.com/n/aJanuary 19 2015 08:38 UTC
Sphere.cpp5.4 KBJanuary 19 2015 13:52 UTC
Comments
Marc Tannouson January 17 2015 20:58 UTCTask Claimed

I would like to work on this task.

Deepak on January 17 2015 21:10 UTCTask Assigned

This task has been assigned to Marc Tannous. You have 43 hours to complete this task, good luck!

Marc Tannouson January 18 2015 20:28 UTCPatched without any problems.

 -

Marc Tannouson January 19 2015 08:38 UTCReady for review

The work on this task is ready to be reviewed.

Marc Tannouson January 19 2015 08:39 UTCabout www.google.com

had to upload something to mark task completed. Explained Andrei over IRC my situation, patch applies perfectly but there might be an issue with the repo or make on my machine, wanted to mark it as complete now because I'll be in school until the gci ends so I can't submit anything else.

Daniel_R on January 19 2015 09:21 UTCTask Needs More Work

One of the mentors has sent this task back for more work. Talk to the mentor(s) assigned to this task to satisfy the requirements needed to complete this task, submit your work again and mark the task as complete once you re-submit your work.

Daniel_R on January 19 2015 09:21 UTCDeadline extended

The deadline of the task has been extended with 2 days and 0 hours.

Daniel_R on January 19 2015 09:25 UTC???

Task wasn't to apply the patch but to run the unit test.  You wrote the patch by yourself, so applying it shouldn't be a problem for you.  But did you compile it?

Marc Tannouson January 19 2015 09:29 UTCcheck irc

Pinged you with the issue..got a fresh repo and tried making the tests, but there is an issue. Can you please tell me if it is only on my machine?

Daniel_R on January 19 2015 09:39 UTCFirst you have to compile

First you have to compile brlcad, then the core interface, then the test.  What did you compiled until now?


BTW, I saw your question on IRC but after 10 min you quit.

Marc Tannouson January 19 2015 13:52 UTCTest worked, after some modifications

marc@marc-To-be-filled-by-O-E-M:~/clean/rt3build$ make tester_ci_primitives
[ 88%] Built target coreinterface
Scanning dependencies of target tester_ci_primitives
[ 92%] Building CXX object tests/coreInterface/CMakeFiles/tester_ci_primitives.dir/Sphere.o
Linking CXX executable ../../tests-bin/tester_ci_primitives
[100%] Built target tester_ci_primitives


Uploaded is a new "Sphere.cpp", which fixes all the errors that applying the patch caused with the test ( stuff like functions/constructors/methods not being properly capitalized or libraries not being included). It's been a great GCI, I enjoyed every day of it.


Regards,


Marc

Marc Tannouson January 19 2015 13:52 UTCReady for review

The work on this task is ready to be reviewed.

Daniel_R on January 19 2015 13:58 UTCTask Closed

Congratulations, this task has been completed successfully.