Fix at least 8 spelling mistakes in at least 8 different filesBRL-CAD
Status: ClosedTime to complete: 72 hrs Mentors: SeanTags:

BRL-CAD is huge. Thousands of files spread across 165 directories. Maintaining a high quality of source code and documentation is a never ending task, but one anyone can help with.

Sound's easy, but you might be surprised because you need to ignore all of the source code and function variables that will easily trip up any automatic spell-check program. You basically only care about spelling mistakes within comments. Even for our documentation, much of it is formatted in xml and you have to ignore all of the xml tags.

This task involves finding and fixing simple spelling mistakes. To complete the task, you need to find 8 or more different spelling mistakes in at least 8 different files. You have to fix all occurrences of the spelling mistake across all those files. Make sense?

Remember to check and fix all occurrences of the mistakes in all 8+ files, make and submit it as a patch file.

BE SURE TO HAVE UP-TO-DATE SOURCES!!! We find and fix spelling mistakes on a daily basis and throughout the day. You have to find mistakes that are not already fixed or reported.

To clarify:

  • 1 mistake in 7 different files counts as: 1 and 7
  • 20 mistakes in 2 files counts as: 8 and 2
  • 5 mistakes across 20 files counts as: 5 and 8
  • You need to find: =8 mistakes AND =8 files
Uploaded Work
File name/URLFile sizeDate submitted
gcidavidgumberg.patch11.9 KBNovember 23 2013 00:36 UTC
gcidavidgumbergnew.patch360 bytesNovember 24 2013 07:37 UTC
gcidavidgumberfinal.patch5.4 KBNovember 24 2013 07:43 UTC
again.patch11.8 KBNovember 26 2013 05:02 UTC
patch.spell28.5 KBJanuary 05 2014 08:10 UTC
Comments
David Gumbergon November 19 2013 02:25 UTCTask Claimed

I would like to work on this task.

Harmanpreet on November 19 2013 02:26 UTCTask Assigned

This task has been assigned to David Gumberg. You have 72 hours to complete this task, good luck!

David Gumbergon November 21 2013 23:56 UTCDelay

Due to an unexpected flood of schoolwork, this task will not be completed in time.

Harmanpreet on November 22 2013 00:45 UTCDeadline extended

The deadline of the task has been extended with 0 days and 23 hours.

David Gumbergon November 22 2013 00:47 UTCBroadness of task

When it says spelling errors, does that include general grammatical errors, or strictly the misspelling of a word?

Harmanpreet on November 22 2013 00:49 UTCDeadline Extended

Not a problem David. I just extended the deadline for your task. We really want you to enjoy working with BRL-CAD and not to make you work in stressful conditions. 


If you need more time, you can again inform us.


Best of luck!

David Gumbergon November 22 2013 00:50 UTCThanks

Thanks for the extension!

David Gumbergon November 22 2013 04:20 UTCHey Harmanpreet

Just to clarify, when it says spelling errors, does that include general grammatical errors, or strictly the misspelling of a word?

Harmanpreet on November 22 2013 04:41 UTCOnly Spellings

For this task, you just need to check spelling errors.

David Gumbergon November 22 2013 04:59 UTCSpelling Style

In terms of spelling style, should it be US english or UK english?

Harmanpreet on November 22 2013 06:08 UTCUS English

It should be in US English.

David Gumbergon November 23 2013 00:38 UTCReady for review

The work on this task is ready to be reviewed.

Melange on November 23 2013 02:13 UTCNo more Work can be submitted

Melange has detected that the deadline has passed and no more work can be submitted. The submitted work should be reviewed.

Sean on November 23 2013 02:52 UTCclose!

David,


In reviewing your patch, I only count five files with spelling changes and several of the spelling changes were "questionable".  That said, fixing the spelling of Acknowledgments is something that will get your file count up past the minimum required.  Fix all of them and you will have completed the task.  If you use Mac or Linux, you can find them all quickly with this:


grep -r -i acknowledgement doc/* |grep -v svn


42 instances in 24 files.


 

Sean on November 23 2013 02:52 UTCDeadline extended

The deadline of the task has been extended with 1 days and 12 hours.

Sean on November 23 2013 02:52 UTCTask Needs More Work

One of the mentors has sent this task back for more work. Talk to the mentor(s) assigned to this task to satisfy the requirements needed to complete this task, submit your work again and mark the task as complete once you re-submit your work.

David Gumbergon November 23 2013 04:02 UTCMistake in use of diff tool

I just reviewed my patch file and I must have made a mistake with diff, as I made sure to duly note all my corrections in a seperate document. Can you clarify whoch fixes were questionable? I can replace them with more adequate corrections if necessary.

David Gumbergon November 24 2013 07:38 UTCIgnore the recently uploaded file

Please ignore the recently mistakenly uploaded patch file.

David Gumbergon November 24 2013 07:44 UTCReady for review

The work on this task is ready to be reviewed.

Melange on November 24 2013 20:39 UTCNo more Work can be submitted

Melange has detected that the deadline has passed and no more work can be submitted. The submitted work should be reviewed.

Sean on November 25 2013 03:51 UTCDeadline extended

The deadline of the task has been extended with 1 days and 12 hours.

Sean on November 25 2013 03:51 UTCTask Needs More Work

One of the mentors has sent this task back for more work. Talk to the mentor(s) assigned to this task to satisfy the requirements needed to complete this task, submit your work again and mark the task as complete once you re-submit your work.

Sean on November 25 2013 04:01 UTCsame patch

David, your previous patch file was "reversed" but that's not a problem.  The issue, as I noted, was that there were only a few spelling fixes.  Note that fixing grammar or simply swapping one word for another similar/better/different word do not count.  The task is spelling fixes.


If you do not see the issue, itemize what mispellings your patch fixes.


That said, I noted that you can attain the minimum required by fixing all instances of acknowledgement to the U.S. spelling, acknowledgment.


p.s. Note that if you have an svn checkout (if you have .svn directories in your source tree, you have a checkout), you can create a suitable patch file with the "svn diff" command:  svn diff mychanges.patch


 

David Gumbergon November 26 2013 04:38 UTCNot reversed

I did reverse the patch, but I added 3 more instances of correcting the word "acknowledgments". Was that not enough? I now have 11 corrections v 8? Anyways, I'm going to add more corrections of the word to satisfy the requirement.

David Gumbergon November 26 2013 05:02 UTCReady for review

The work on this task is ready to be reviewed.

Sean on November 26 2013 06:18 UTCplease itemize them

First and foremost, the submission should be in universal patch format, not just a series of diffs.  These instructions may help:


http://brlcad.org/wiki/Deuces#When_You.27re_Done


or


http://brlcad.org/wiki/Patches


That said, please summarize what spelling corrections you've made and in what files here as a comment.  Like this:


doc/docbook/file.xml



  • fxed - fixed

  • wrd - word


Note that the task also requires you to fix all occurances of any mistake you made across all the file(s) that you end up editing.  I'd suggested earlier that you fix all of them at once:


grep -r -i acknowledgement doc/* |grep -v svn



Sean on November 26 2013 06:18 UTCTask Needs More Work

One of the mentors has sent this task back for more work. Talk to the mentor(s) assigned to this task to satisfy the requirements needed to complete this task, submit your work again and mark the task as complete once you re-submit your work.

Sean on November 26 2013 06:19 UTCDeadline extended

The deadline of the task has been extended with 2 days and 0 hours.

Melange on November 29 2013 21:51 UTCTask Reopened

Melange has detected that the final deadline has passed and it has reopened the task.

David Gumbergon November 29 2013 22:02 UTCTask Claimed

I would like to work on this task.

Sean on November 29 2013 22:35 UTCTask Assigned

This task has been assigned to David Gumberg. You have 72 hours to complete this task, good luck!

Melange on December 2 2013 22:35 UTCInitial Deadline passed

Melange has detected that the initial deadline has passed and it has set the task status to ActionNeeded. The student has 24 hours to submit the work before the task is reopened and sent back to the pool for other students to claim.

Melange on December 3 2013 22:35 UTCTask Reopened

Melange has detected that the final deadline has passed and it has reopened the task.

Deep Inder Singhon December 9 2013 12:46 UTCTask Claimed

I would like to work on this task.

Daniel Rossberg on December 9 2013 13:59 UTCTask Assigned

This task has been assigned to Deep Inder Singh. You have 72 hours to complete this task, good luck!

Melange on December 12 2013 13:59 UTCInitial Deadline passed

Melange has detected that the initial deadline has passed and it has set the task status to ActionNeeded. The student has 24 hours to submit the work before the task is reopened and sent back to the pool for other students to claim.

Deep Inder Singhon December 13 2013 06:22 UTCDelay

Sorry for Delay due to my  final exams and network problem


Can you please extend my deadline so that i can work on this task.


And can you Please provide me a link from where i download the files from which mistakes has to find.


Thanx.


Regards

Deep Inder Singhon December 13 2013 11:47 UTCClaim Removed

The claim on this task has been removed, someone else can claim it now.

Deep Inder Singhon December 13 2013 11:47 UTCTask Claimed

I would like to work on this task.

Sean on December 13 2013 19:04 UTCTask Assigned

This task has been assigned to Deep Inder Singh. You have 72 hours to complete this task, good luck!

Deep Inder Singhon December 14 2013 08:19 UTCClaim Removed

The claim on this task has been removed, someone else can claim it now.

Sean on January 3 2014 07:10 UTCnobody?

This task is so close to completion, just was submitted in the wrong format.  Is nobody really going to claim it and submit it as a proper patch?  It's basically done.


 

Armenon January 3 2014 19:10 UTCTask Claimed

I would like to work on this task.

Mandeep Kaur on January 3 2014 19:12 UTCTask Assigned

This task has been assigned to Armen. You have 72 hours to complete this task, good luck!

Armenon January 4 2014 01:20 UTCClaim Removed

The claim on this task has been removed, someone else can claim it now.

Shardul Chiplunkaron January 5 2014 05:51 UTCTask Claimed

I would like to work on this task.

Sean on January 5 2014 06:21 UTCTask Assigned

This task has been assigned to Shardul Chiplunkar. You have 72 hours to complete this task, good luck!

Shardul Chiplunkaron January 5 2014 08:10 UTCReady for review

The work on this task is ready to be reviewed.

Shardul Chiplunkaron January 5 2014 08:13 UTCDavid's Patch as Unified Diff

I've tried to convert David's patch to a unified diff format patch by applying it to a fresh checkout and running `svn diff`, but I'm not sure if all his changes have been correctly applied because his patch would not apply cleanly without some modification.

Sean on January 5 2014 17:36 UTCapplied

Your patch was applied in r59281. Thanks Shardul!


It had to be modified slightly.  I don't think our usage of the Docbook xml "acknowledgements" tag can be changed (maybe, didn't test).  We should probably be using "othercredit" anyways instead.


 

Sean on January 5 2014 17:36 UTCTask Closed

Congratulations, this task has been completed successfully.