Update qsort() calls to bu_sort()BRL-CAD
Status: ClosedTime to complete: 72 hrs Mentors: SeanTags: C, refactoring, portability

This task is a follow-on to http://www.google-melange.com/gci/task/view/google/gci2013/5876128501727232

We call qsort() in about 40 places throughout BRL-CAD.  You can run this to find most of them:

grep -r 'qsort(' src/* | grep -v other | grep -v svn

We have a new function in our LIBBU portable utility library, bu_sort(), that provides functionality nearly identical to qsort_s() on Windows or qsort_r() on Linux.  The difference between sort() and those functions is that you have to put data into global variables with sort() but you pass data as an argument with the others.  

This task involves updating five or more instances of qsort (you must at least update all occurrences in a given file) to bu_sort.

Basically, you'll take any parameter that was being accessed as a global and pass it as an argument.  If the variable can be moved from global into a local scope during the transition, even better, but the important step is to update the callback function to take an additional parameter and to access data through that parameter, not via the global.  If multiple globals are accessed, you'll need to create a struct that combines them together.

Submit your work as a patch file.

There are multiple tasks like this one in order to see all occurrences get fixed.  If you run into any qsort() call that takes more than an hour to convert, for whatever reason, let us know.

 
Uploaded Work
File name/URLFile sizeDate submitted
https://sourceforge.net/p/brlcad/code/59069/n/aDecember 19 2013 21:39 UTC
Comments
Johannes Schulteon December 19 2013 20:23 UTCTask Claimed

I would like to work on this task.

Sean on December 19 2013 20:24 UTCTask Assigned

This task has been assigned to Johannes Schulte. You have 72 hours to complete this task, good luck!

Johannes Schulteon December 19 2013 21:39 UTCReady for review

The work on this task is ready to be reviewed.

Johannes Schulteon December 19 2013 21:40 UTC

When reviewing this task, please also take a look at my question under this task : https://google-melange.appspot.com/gci/task/view/google/gci2013/5784907422892032

Sean on December 20 2013 05:24 UTClooks good

Looks great, but why the (size_t *) casts to a void* arg when it was already a void*?


 

Sean on December 20 2013 05:24 UTCTask Closed

Congratulations, this task has been completed successfully.

Johannes Schulteon December 20 2013 12:10 UTC

the casts were copypaste remains, fixed that (besides other stuff) in r59087