Append CMake build flags to the end of a compile line

Append CMake build flags to the end of a compile lineBRL-CAD

Status: ClosedTime to complete: 48 hrs Mentors: SeanTags: cmake, build system, flags, compilation

This is a follow-on task to http://www.google-melange.com/gci/task/view/google/gci2012/7984228

Instead of having environment variables get appended to the beginning or middle of a flags list, make them get added to the end. It's often a case when compiling that you need to override a flag or path getting set, so we need the ability to both prepend and affix flags to the end of a compilation/linker line.

Provide a patch and output log showing it works.

Uploaded Work

File name/URL	File size	Date submitted
compilerflags_cmake_fix.patch	2.2 KB	December 20 2012 03:10 UTC
brlcad_cmake_result.log	2.8 KB	December 20 2012 03:10 UTC
compilerflags_cmake_fix.patch	1.4 KB	December 21 2012 05:50 UTC
brlcad_cmake_result.log	7.1 KB	December 21 2012 05:52 UTC

Comments

gckingon December 19 2012 17:09 UTCTask Claimed

I would like to work on this task.

Andrei Popescu on December 19 2012 17:10 UTCTask Assigned

This task has been assigned to gcking. You have 48 hours to complete this task, good luck!

gckingon December 20 2012 03:10 UTCReady for review

The work on this task is ready to be reviewed.

gckingon December 20 2012 19:22 UTCReady for review

Can you please review my work?

Sean on December 20 2012 19:34 UTCdoesn't look right...

So at a glance, your output doesn't show it working... There are flags both before and after the two cflags you set. I'd expect -DCOWGOES... to be the first flag before -Werror and -DTEST=1 to be the last flag after -msse3...

Also related to you prior task, I've found bugs if you re-run cmake or run cmake with a build mode (Debug/Release) set, so you might want to check that as well. We can make a separate task to fix them, but there's definitely more work that the first patch implied.

Sean on December 20 2012 19:34 UTCTask Needs More Work

One of the mentors has sent this task back for more work. Talk to the mentor(s) assigned to this task to satisfy the requirements needed to complete this task, submit your work again and mark the task as complete once you re-submit your work.

Sean on December 21 2012 05:03 UTCmore time

Let us know if you need more time. This one may be a little tricky as you'll probably have to edit other files and/or put commands into a macro.

gckingon December 21 2012 05:52 UTCReady for review

The work on this task is ready to be reviewed.

gckingon December 21 2012 05:56 UTCtest under both debug and release mode

I tested the script under both debug and release mode, but I did not find out the error you mentioned below. I attached the result log file including both debug and release mode, please review it.

gckingon December 21 2012 17:03 UTCReady for review

Can you please review my work?

Melange on December 21 2012 17:10 UTCNo more Work can be submitted

Melange has detected that the deadline has passed and no more work can be submitted. The submitted work should be reviewed.

Sean on December 22 2012 13:33 UTCworks with and without cache set?

Did you test with and without a previous cmake cache'd result?

I'm seeing variables getting joined together here, but it could be my older version.

Sean on December 22 2012 13:46 UTCTask Closed

Congratulations, this task has been completed successfully.