Menu
Logged-In As
ACCOUNTNot Logged In
Create a numerics library (LIBBN) API unit test ... for vert_tree.cBRL-CAD
Status: ClosedTime to complete:
48 hrs
Mentors: Sean
There are more than 300 library functions in our core LIBBN library. As a core library used by nearly every one of BRL-CAD's tools, testing those functions for correct behavior is important.
This task involves implementing a new unit test for any of LIBBN's source files that do not already have a unit test defined. The test should run all of the public functions and be hooked into our build system (if written in C). We have lots of existing unit tests to follow as an example.
You can implement this task in any language you like, but you'll have to bind all of the functions you test.
References:
- include/bn.h
- src/libbn/vert_tree.c
- src/libbu/tests/*.c
- src/libbn/tests/*.c
Code:
- src/libbn/tests/bn_vert_tree.c
- src/libbn/tests/CMakeLists.txt
Uploaded Work
File name/URL | File size | Date submitted | |
---|---|---|---|
vert_test.patch | 12.0 KB | January 02 2013 15:48 UTC | |
vert_test_2.patch | 19.6 KB | January 04 2013 15:49 UTC | |
vert_test_2_1.patch | 19.6 KB | January 04 2013 15:56 UTC | |
vert_test_2_2.patch | 19.6 KB | January 04 2013 15:58 UTC | |
vert_test_2_3.patch | 19.6 KB | January 04 2013 16:01 UTC |
I would like to work on this task.
This task has been assigned to Silvrous. You have 48 hours to complete this task, good luck!
Melange has detected that the initial deadline has passed and it has set the task status to ActionNeeded. The student has 24 hours to submit the work before the task is reopened and sent back to the pool for other students to claim.
The deadline of the task has been extended with 1 days and 0 hours.
The deadline of the task has been extended with 0 days and 2 hours.
The work on this task is ready to be reviewed.
Melange has detected that the deadline has passed and no more work can be submitted. The submitted work should be reviewed.
The patch looks good, but I did notice a few issues:
Nice inclusion of typo fixes in the related file. :)
Apologies on the delay .. Happy New Year!
One of the mentors has sent this task back for more work. Talk to the mentor(s) assigned to this task to satisfy the requirements needed to complete this task, submit your work again and mark the task as complete once you re-submit your work.
The deadline of the task has been extended with 2 days and 0 hours.
The work on this task is ready to be reviewed.
Tests 6,10 and 11 fail, but I'm certain the return result should be what I specified in the test. Is it possible that there is a bug in the Add_vert_and_norm() function?
There were a couple of formatting errors, the latest patch (2_3) is be the corect one.
Melange has detected that the deadline has passed and no more work can be submitted. The submitted work should be reviewed.
Congratulations, this task has been completed successfully.
It's entirely possible that there's a bug in the Vert_test interface. Frankly, I'm a little dubious of some of our other new unit tests because they didn't encounter (or report) a bug. It'll take some work to investigate whether you found a bug but it's good work either way. Thanks for your efforts!