Remove (void) before sscanf/scanf/fprintf/printf/bu_log function callsBRL-CAD
Status: ClosedTime to complete: 72 hrs Mentors: Sean, Daniel RossbergTags: C, C++, code cleanup, simple, script, perl, python, ruby, php

BRL-CAD is a huge codebase with a lot of history.  At one point back in time, it was common practice (and even necessary) to cast C function call return values to (void) to indicate that we're not using them:

(void)printf("hello world\n");

This task involves finding all of the undocumented instances throughout our code where that (void) marker precedes a call to sscanf(), scanf(), fprintf(), printf(), or bu_log().  Do not remove (void) if there's a comment near that statement that indicates it is required.

This task will touch hundreds of files throughout the source tree, so be very careful if you write a script to help automate the work.   You should still manually inspect the svn diff before submitting your patch file to make sure there are not any erroneous changes.

Your patch MUST apply cleanly so be sure you have a recent trunk source checkout.  See these for help:

http://brlcad.org/wiki/Deuces#Getting_Started

http://brlcad.org/wiki/Deuces#When_You.27re_Done

 

Uploaded Work
File name/URLFile sizeDate submitted
void.patch280.4 KBDecember 03 2012 08:35 UTC
Comments
reikazeon November 30 2012 11:53 UTCTask Claimed

I would like to work on this task.

Andrei Popescu on November 30 2012 12:02 UTCTask Assigned

This task has been assigned to reikaze. You have 72 hours to complete this task, good luck!

reikazeon December 3 2012 08:35 UTCReady for review

The work on this task is ready to be reviewed.

Daniel Rossberg on December 3 2012 10:17 UTCTask Closed

Congratulations, this task has been completed successfully.

Daniel Rossberg on December 3 2012 10:19 UTCLooks OK for me

I don't know if these were really all occurences, but they are many and it builds and test, benchmark and mged are looking ok.


Daniel

Sean on December 3 2012 16:40 UTCattribution

Reikaze, if you provide your full name, we'll credit you accordingly in our authorship file.  Thanks for your efforts!

Sean on January 10 2013 05:56 UTCfyi


It looks like you only need to complete one more task for the free t-shirt!


Sean on January 14 2013 14:56 UTCthank you

As GCI comes to a close, we wanted to take the time to say THANK YOU for all your efforts.  This comment interface closes after GCI is over, so you're encouraged to join our mailing list where we'll be announcing contributions from GCI participants like yourelf over the upcoming months: 


https://lists.sourceforge.net/lists/listinfo/brlcad-news


If you've provided your full name, we'll be sure to credit you in our authorship documentation and you'll see your name in a future announcement.  If you contact us at devs@brlcad.org or via IRC, we'll even let you know when your work is integrated and follow up with updates.  You're welcome and encouraged to contact us any time, especially if you have a question about how to continue participating in Open Source after GCI is over, but even if just to keep in touch.  Note that ongoing participation in Open Source is one of the most impressive skills to have on your resumé.  Take care, be well, and thank you again!