Menu
Logged-In As
ACCOUNTNot Logged In
Modify IRC notifier outputBRL-CAD
Status: ClosedTime to complete:
48 hrs
Mentors: Sean, Erik
We have an IRC notification service (an IRC bot) that make announcements to our #brlcad IRC channel on Freenode. The service was recently set up to even post GCI notifications, but right now they're very verbose:
GCI: Sean has left the following comment at Create an RTWizard screenshot http://www.google-melange.com/gci/task/view/google/gci2012/8034204: that's not rtwizard You made a screenshot of 'mged', but that's the wrong application...
We'd like that to be just a little bit more concise, something like this:
GCI:Sean * 8034204 Create an RTWizard screenshot: that's not rtwizard - You made a screenshot of 'mged', but that's the wrong application...
This task requires editing the Lisp sources for the bot at https://github.com/erikg/cl-cia/blob/master/maildir.lisp #'do-gci-email
The problem starts at #'process-brlcad-gci-mail-dir.
Let us know when you have a git pull request or post a patch here.
References
- https://github.com/erikg/cl-cia/blob/master/maildir.lisp
- irc://freenode.net/#brlcad
Join our IRC channel to see the notifier in action.
Uploaded Work
| File name/URL | File size | Date submitted | |
|---|---|---|---|
| https://github.com/erikg/cl-cia/pull/1 | n/a | December 18 2012 00:12 UTC | |
| https://github.com/erikg/cl-cia/pull/2 | n/a | December 20 2012 18:21 UTC | |
| gci-notifer.patch | 39.5 KB | December 20 2012 21:01 UTC | |
| https://github.com/erikg/cl-cia/pull/2 | n/a | January 07 2013 21:10 UTC | |
| GCI-Maildir.patch | 2.0 KB | January 07 2013 21:11 UTC |
I would like to work on this task.
This task has been assigned to Jacob B. You have 48 hours to complete this task, good luck!
The work on this task is ready to be reviewed.
Melange has detected that the deadline has passed and no more work can be submitted. The submitted work should be reviewed.
One of the mentors has sent this task back for more work. Talk to the mentor(s) assigned to this task to satisfy the requirements needed to complete this task, submit your work again and mark the task as complete once you re-submit your work.
The deadline of the task has been extended with 1 days and 0 hours.
Notice how the pull request shows every line in the file changing:
https://github.com/maths22/cl-cia/commit/dad68e924319de0475afd8db603b1ee4d071287f
That's not right. You're introducing or otherwise chaning the existing end-of-line character so every line gets changed. It's not practical to review that way.
I updated it and fixed the line endings. I can't get testing working, so I have to hope it works.
The work on this task is ready to be reviewed.
So looking at your git history, I still can't tell what exactly you've changed because three of the five commits changes every line in the file and the two one-liner commits undoes itself. Your work needs to be reviewable without all of that mess. Provide a patchfile *here* so the GCI task can be reviewed independently of whether your pull request gets merged. The patch file should contain only the edits you intended to make and not all the newline mess.
One of the mentors has sent this task back for more work. Talk to the mentor(s) assigned to this task to satisfy the requirements needed to complete this task, submit your work again and mark the task as complete once you re-submit your work.
The deadline of the task has been extended with 1 days and 0 hours.
I would make a patch, but I cannot figure out how to do so. My changes are pretty clear in the pull request, however.
The work on this task is ready to be reviewed.
There are hundreds of websites around the web that go into excruciating detail on what patch files are, how to make them, how to apply them, etc. Are you saying you cannot figure out how to do a web search? :)
One of the mentors has sent this task back for more work. Talk to the mentor(s) assigned to this task to satisfy the requirements needed to complete this task, submit your work again and mark the task as complete once you re-submit your work.
The deadline of the task has been extended with 1 days and 0 hours.
The work on this task is ready to be reviewed.
One of the mentors has sent this task back for more work. Talk to the mentor(s) assigned to this task to satisfy the requirements needed to complete this task, submit your work again and mark the task as complete once you re-submit your work.
Melange has detected that the final deadline has passed and it has reopened the task.
I would like to work on this task.
This task has been assigned to Jacob B. You have 48 hours to complete this task, good luck!
Melange has detected that the initial deadline has passed and it has set the task status to ActionNeeded. The student has 24 hours to submit the work before the task is reopened and sent back to the pool for other students to claim.
Melange has detected that the final deadline has passed and it has reopened the task.
I would like to work on this task.
I had winter break, and I could not work on GCI then.
This task has been assigned to Jacob B. You have 48 hours to complete this task, good luck!
The work on this task is ready to be reviewed.
Congratulations, this task has been completed successfully.