| Latest revision |
Your text |
| Line 53: |
Line 53: |
| | | | |
| | /libtclcad/tclcadobj.c - | | /libtclcad/tclcadobj.c - |
| − | 1) functions "HIDDEN int to_mouse_move_arb_edge", "HIDDEN int to_mouse_move_arb_face" and "HIDDEN int to_mouse_move_pipept". The difference's in:
| + | ***functions "HIDDEN int to_mouse_move_arb_edge", "HIDDEN int to_mouse_move_arb_face" and "HIDDEN int to_mouse_move_pipept". The difference's in: |
| | av[0] = "move_arb_face"; - to_mouse_move_arb_face | | av[0] = "move_arb_face"; - to_mouse_move_arb_face |
| | av[0] = "move_arb_edge"; - to_mouse_move_arb_edge | | av[0] = "move_arb_edge"; - to_mouse_move_arb_edge |
| Line 64: |
Line 64: |
| | | | |
| | So these functions could call another static function which'd have all the body and get char * parameter for av[0] and functional type for ret. | | So these functions could call another static function which'd have all the body and get char * parameter for av[0] and functional type for ret. |
| − | 2) functions "HIDDEN int to_poly_ell_mode" and "HIDDEN int to_poly_circ_mode". Differnce's in consts - gdvp->gdv_view->gv_mode = TCLCAD_POLY_ELLIPSE_MODE; and gdvp->gdv_view->gv_mode = TCLCAD_POLY_CIRCLE_MODE; so necessary const could be got by common function (type - ged_view, if I'm not mistaken). Also difference is in bu_vls_printf, but type char* can be transmit too.
| + | ***functions "HIDDEN int to_poly_ell_mode" and "HIDDEN int to_poly_circ_mode". Differnce's in consts - gdvp->gdv_view->gv_mode = TCLCAD_POLY_ELLIPSE_MODE; and gdvp->gdv_view->gv_mode = TCLCAD_POLY_CIRCLE_MODE; so necessary const could be got by common function (type - ged_view, if I'm not mistaken). Also difference is in bu_vls_printf, but type char* can be transmit too. |
| | | | |
| | /librt/primitives/nmg/nmg_rt_segs.c - functions "HIDDEN int state5" and "HIDDEN int state6". It'd be easy to reduct, because difference's only in ret_val (in two situations at the end of functions) which is INT. So I'd be necessary only to transmit ret_val1 and ret_val2. | | /librt/primitives/nmg/nmg_rt_segs.c - functions "HIDDEN int state5" and "HIDDEN int state6". It'd be easy to reduct, because difference's only in ret_val (in two situations at the end of functions) which is INT. So I'd be necessary only to transmit ret_val1 and ret_val2. |
| Line 84: |
Line 84: |
| | | | |
| | *4/06 - getting familiar with unit tests | | *4/06 - getting familiar with unit tests |
| − |
| |
| | *5/06 - cheking some more directories for duplications | | *5/06 - cheking some more directories for duplications |
| − |
| |
| | *6/06 - CMakeFiles and Makefile | | *6/06 - CMakeFiles and Makefile |
| − | | + | *7/06 - patch for src/util - files util.c and util.h. util_yuv is almost ready (something need to be checked) |
| − | *7/06 | + | *8/06 - working with util_yuv and come back to firt patch (ready *need to send patch) |
| − | **patch for src/util - files util.c and util.h.
| + | *9/06 - /mged/cmd.c is refactored, work with /libtclcad/tclcadobj.c. Have some problems with functional type |
| − | **util_yuv is almost ready (something need to be checked)
| |
| − | | |
| − | *8/06 | |
| − | **working with util_yuv (ready)
| |
| − | **come back to firt patch (ready *need to send patch)
| |
| − | | |
| − | *9/06 | |
| − | **/mged/cmd.c is refactored
| |
| − | **work with /libtclcad/tclcadobj.c. Have some problems with functional type
| |
| − | **/fb/pl-fb.c is refactored. Static inline function is added. Making and running are successful
| |
| − | | |
| − | == 4 week ==
| |
| − | *11/06
| |
| − | **further checking for duplications in one directory, different files
| |
| − | *12/06
| |
| − | **the same checking. Hope to finish it by today's evening
| |
| − | *13/06
| |
| − | **sent all prepared patches,
| |
| − | **did some making and running of refactored functions to be sure in right result.
| |
| − | *14/06
| |
| − | **/librt/primitives/nmg/nmg_rt_segs.c is refactored
| |
| − | **some more checking
| |
| − | *15/06
| |
| − | **checking for copy-pastes in 1 dir - different files is completed! The count of such places -- 14, +2 are already patched
| |
| − | *16/06
| |
| − | **getting familiar with u-f.c, d-i.c etc. Understanding how they work.
| |
| − | | |
| − | == 5 week ==
| |
| − | *18/06
| |
| − | **reduction in sig/d-i.c and ../f-i.c. Patch's added
| |
| − | *19-20/06
| |
| − | **reduction in libged/view_obj.c and ../vutil.c. 2 functions're put in util.c
| |
| − | **reduction in libdm. There're quite enough dups, so need a bit more time to finish
| |
| − | *21/06
| |
| − | **reduction in libdm is finished
| |
| − | *23/06
| |
| − | **find a bit more in libdm, add it
| |
| − | | |
| − | == 6 week ==
| |
| − | *25/06
| |
| − | **getting familiar with g-nff, g-obj, g-xxx_facets
| |
| − | *26/06
| |
| − | **reduction in src/conv for g-nff, g-obj and g-xxx_facets is done
| |
| − | **made small man pages for src/sig: f-i, d-i, u-f, i-f
| |
| − | *27/06
| |
| − | **made man pages for src/sig: a-d, bw-d, d2-c, d-a, d-bw, d-u, f-d, u-bw, u-d
| |
| − | *28-29/06
| |
| − | **check duplications in different folders. Most dups've already been found. Hope to finish by tomorrow evening and make a whole report by them
| |
| − | *30/06
| |
| − | **all the duplicaions in differesnt foldres are checked. There're about 35 such situations. Some of them are a bit disputed and needed to be discussed.
| |
| − | | |
| − | == 7 week ==
| |
| − | *02/06
| |
| − | **worked with libged/ps.c and png.c but unsuccessful. They couldn't be reducted
| |
| − | *03-04/06
| |
| − | **looked through left TODOs. Tomorrow will finish it and reduct.
| |
| − | TODO: to correct existing patches a bit
| |
| − | *05/06
| |
| − | **did some reduction in
| |
| − | /liboptical/sh_camo.c and /tclcad/tclcad_obj.c (thanks to ``Erik). Will patch them in a few days because of some problems with my laptop
| |
| − | | |
| − | == 8 week ==
| |
| − | *09-10/07
| |
| − | **added patch for /liboptical/sh_camo.c
| |
| − | **submitted my Student Midterm Evaluation
| |
| − | **checked some previous patches
| |
| − | **work on reduction in sig/umod.c and sig/imod.c. It must be the last reduction for 1 directiory - many files
| |
| − | *14/07
| |
| − | **spent some time reading HACKING file
| |
| − | | |
| − | During the first part of GSoC program I:
| |
| − | | |
| − | 1. Found, reducted (where it was possible) and patched all the duplications which are contained in ONE (the same) file
| |
| − | | |
| − | 2. Found, reducted (where it was possible) and patched all (except one) the duplications which are contained in different files, but in one directory. Usually I added 2 new files - util.c and util.h, which contained the duplicated code. I need to add some necessary comments to the new files.
| |
| − | | |
| − | 3. Created some small manual pages for some programs in src/sig. Will commit them after the getting commit access.
| |
| − | | |
| − | 4. Found all the duplications which are contained in different directories and have a full list of necessary reductions.
| |
| − | | |
| − | == 9 week ==
| |
| − | *16/07
| |
| − | **working on headers from some previous patches
| |
| − | *18/07
| |
| − | **updated patches for src/util
| |
| − | *21-22/07
| |
| − | **updated patches for other duplications in 1 directiory - different files
| |
| − | | |
| − | == 10 week ==
| |
| − | *26/07
| |
| − | **updated patches for src/conv
| |
| − | **added patch for src/librt/primitives/nmg/nmg_rt_segs.c
| |
| − | *27/07
| |
| − | **found several editing methods for duplicate code in different folders
| |
| − | **trying to reduct code in different folders
| |
| − | *28/07
| |
| − | **updated patch for src/fb/pl-fb.c
| |
| − | **updated patches for src/libdm
| |
| − | **closed unnecessary patch for src/libdm
| |
| − | **checking other patches
| |
| − | *29/07
| |
| − | **updated two patches for src/sig
| |
| − | **updated two patches for src/utils
| |
| − | **added comments for patches on patches tracker where it was necessary
| |
| − | | |
| − | == 11 week ==
| |
| − | *30/07
| |
| − | **fixed error at patch for src/libdm
| |
| − | **reducted patch for fb/pl-fb.c
| |
| − | **added some screenshots for patches
| |
| − | *31/07
| |
| − | **continue working with clip.c.in libbn
| |
| − | *1/08
| |
| − | **some work on previous patches
| |
| − | *2-3/08
| |
| − | **clip.c.in libbn is ready. Now there're 3 functions, commmon for libdm and libged
| |
| − | | |
| − | == 12 week ==
| |
| − | *6/08
| |
| − | **made one more reduction in libbn. Now there're files track_reg.c and track_reg.h. They have common funtions for libged/track.c and libwdb/reg.c
| |
| − | *8/08
| |
| − | **refactoring in libicv and util. The same as previous
| |
| − | *9/08
| |
| − | **refactoring in fb and libfb. Tha same as previous
| |
| − | *10/08
| |
| − | **some more reductions in previous situations for good patches. Almost everything I supposed to do during GSoC is ready
| |
| − | *12/08
| |
| − | **added 2 more prepared patches
| |
| − | | |
| − | == 13 week ==
| |
| − | | |
| − | *work on cleaning and reviewing the patches
| |
